Skip to content

Remove deepcopy branch for alias_f#3829

Open
jClugstor wants to merge 2 commits into
SciML:masterfrom
jClugstor:alias_f_deepcopy
Open

Remove deepcopy branch for alias_f#3829
jClugstor wants to merge 2 commits into
SciML:masterfrom
jClugstor:alias_f_deepcopy

Conversation

@jClugstor

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The branch is causing issues with JuliaC trimming.

@jClugstor jClugstor marked this pull request as ready for review July 8, 2026 16:05
@jClugstor

Copy link
Copy Markdown
Member Author

@ChrisRackauckas
The deepcopy branch was originally added in the same PR that added the support for using ODEAliasSpecifier, so it was basically added to give alias_f something to do I guess. By default f is aliased anyways (alias_f = true), and I can't find a single package that uses alias_f = false, so I think getting rid of it should be safe. I just rebased so CI is still running but there weren't any issues before the rebase.

A question this brings up is now that alias_f doesn't do anything, should we get rid of it in the ODEAliasSpecifier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant